[csg] full isolation from ROOT - #23422
Draft
ferdymercury wants to merge 3 commits into
Draft
ferdymercury wants to merge 3 commits into
ferdymercury wants to merge 3 commits into
Conversation
ferdymercury
added
the
skip code analysis
ferdymercury
marked this pull request as ready for review
September 18, 2026 16:53
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
linev
as code owners
September 18, 2026 16:53
Test Results 22 files 22 suites 3d 11h 41m 39s ⏱️ Results for commit 9c9c9ef. ♻️ This comment has been updated with latest results. |
Member
|
Thanks. PR #23421 was merged a few minutes ago. Something odd happens with the rebase of this one. |
Collaborator
Author
|
Fixed now! |
Member
|
Please wait with such changes - until problem with AIDASoft/DD4hep#1681 resolved |
linev
requested changes
Sep 21, 2026
linev
left a comment
linev
left a comment
Member
There was a problem hiding this comment.
Wait until issue with public API is resolved
ferdymercury
marked this pull request as draft
September 21, 2026 17:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #23421
to fully isolate it from ROOT so it is a standalone builtin like libAfterImage.
That way it can be later replaced by more upstream version of solid3, or by a more modern lib.
I just thought it would be better to have the other one merged first, to be more atomic.